Alin Dima
Alin Dima
We should automate the bindgen process and possibly use it from a build script. We otherwise have no easy way of regenerating them on-demand
Related issue: https://github.com/firecracker-microvm/firecracker/issues/1722
Related to https://github.com/firecracker-microvm/firecracker/issues/1759. In order to remove the `lazy_static` usage we'd need to use per-component metrics. One option for the design is the one linked in the issue.
> Metrics themselves don't need locks since they're atomics, so a solution would also be to decouple the writer from the metric implementation. This is similar to what I was...
> Also I am a bit worried on the performance impact of atomic metrics. As discussed on the issue mentioned above, atomics for metrics on the hotpaths might add a...
The components with global state left are logger, metrics and version_map MMDS was tackled in this PR: https://github.com/firecracker-microvm/firecracker/pull/2920
Related to https://github.com/firecracker-microvm/firecracker/issues/593
I believe this was solved by using the *Events traits, like `SerialEvents` and `RtcEvents`
Good point. > This approach can also be used to fix the problem that you are mentioning in https://github.com/firecracker-microvm/firecracker/pull/2893 In order to fully fix the thread-safety issues, multiple other issues...
> On resuming the VM, the guest soft-lockup watchdog might panic. Remember seeing any such panics?