firecracker icon indicating copy to clipboard operation
firecracker copied to clipboard

Improve documentation and comments on expects/unwraps

Open dianpopa opened this issue 6 years ago • 3 comments

We need to clarify our use of unwraps and expects throughout the code (i.e. gracefully terminate program execution in case of invariant being violated).

dianpopa avatar Jan 03 '19 11:01 dianpopa

One common usecase that we have to consider is dev/kvm not having the proper permissions.

andreeaflorescu avatar Jan 10 '19 13:01 andreeaflorescu

Specifically, the instruction to reset this after rebooting (does it need to be reset after a logout? To be confirmed) needs to go into the Getting Started.

It does not seem to be the case that the setfacl needs to be reset after each invocation of firecracker (see this comment). However, my machine has had enough changes I'm not sure if that is true for a vanilla installation.

bbros-dev avatar Jun 25 '20 02:06 bbros-dev

Related to https://github.com/firecracker-microvm/firecracker/issues/593

alindima avatar Feb 14 '22 15:02 alindima