Alice Frosi
Alice Frosi
@aliamerj please squash the merge commit, we need to have a clean git history. Additionally, could you please rewrite your commit message with a short title and then a brief...
I would completely avoid the direct access to the spec for adding the volumes by adding the proper functions. I think @fossedihelm already also pointed this out. If you don't...
/approve @fossedihelm can you please take another look? /hold to let Federico reviewing this
@hw-claudio not yet. We are still integrating the SEV CI nodes to be able to test the code changes
The code looks good /lgtm
/approve /unhold
@zhenliangliang can you please translate the title and provide a short description of the issue?
@fabiand do you want us to write the rules here or in a follow-up PR?
Additionally, I think before engaging, I'd like to understand the scope of the sig. If this means, we are responsible for all the dependencies, I feel its a huge responsibility....
Can you please provide your yaml? Or how have you created the snapshot? There is probably the version missing there.