Alice Frosi

Results 488 comments of Alice Frosi

@alromeros one general comment also about the commit style, would you mind to use a short title and put a brief description in the commit message body.

I think there still a couple of todos but we can merge this and address them in a follow-up PR. Thanks @alromeros! /approve

Same question as for https://github.com/kubevirt/kubevirt/pull/11955#issuecomment-2126358084

@bougou thanks for the PR! Could you please provide your use-case for the subPath field in the API?I don't quite understand how a user would use it.

> Hi @alicefr We deployed rook-ceph in our K8S cluster, and created a single CephFS PVC (named `data-pvc`) to store data of all users. > > We want to store...

@bougou then the code looks good to me to. Please, add some unit tests as @vasiliy-ul suggested

The function [migratableDomXML](https://github.com/kubevirt/kubevirt/blob/main/pkg/virt-launcher/virtwrap/live-migration-source.go#L268) is hard to extend for new fields that needs to be added or modified for the migrate XML. An example, where this is needed is for storage...