Alice Frosi
Alice Frosi
@aerosouund thanks for working on this :). I'll try to review your work later this week. However, a couple of suggestions about the commits. Try to have clean commit history,...
@aerosouund please, squash some commits together like explained in this thread: https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together
@aerosouund please fix the commit body message in 4eb92005c6aefc7c412409da0a71d99b84eaa5cc and please squash 2a4dad1ec0e428b0fd49071d4ce556142b406ff7 into the first commit
/test all
@aerosouund is this change needed 6485743476a81a3fae26d4d5b40993bebd9b2443 ? I don't see the new functions called in the commit.
@aerosouund the git tree isn't complete clean, probably you forgot to commit all the file, that's why the CI is failing (see the `pull-kubevirt-build` output in `Details`). Please, fix also...
@aerosouund the code at the first glance seems fine to me, but I'd like to check if the tests are passing. The part that you could fix is the commits....
/ok-to-test
/test all