Alice Frosi

@ishankhare07 could you please provide virt-launcher logs of the crashed VM?

@Kuruyia I'd simply create a new binary and replace the vm.sh with it. Writing a cli tool in bash isn't the nicest thing

@anishbista60 there is already an open PR which already address this issue: https://github.com/kubevirt/kubevirtci/pull/1164

@Kuruyia the PR looked already very good to me, I was waiting for @brianmcarey and @dhiller to understand how to integrate it smoothly in the new provider. At least for...

@Kuruyia thanks for the work! Can you implement a couple of unit tests for the functions?

@dhiller @brianmcarey do you have any idea how we could test this?

> > @Kuruyia thanks for the work! Can you implement a couple of unit tests for the functions? > > Hey, thanks for your review! > > I'll address your...

> Hey! Sorry for the delay, I just added the unit tests as you asked, and ported here the NUMA feature that was recently added to `vmcli.sh` as well. >...

> > Yes, I think we could replace the bash script in a second PR. For example, we might need to think also how to transition form it to the...

@Kuruyia please squash the commits that changes the vmcli into a single one, for example, the ones that inline the errors.