Alex Villarreal
Alex Villarreal
It was a regression in api-extractor 7.52.5, fixed in 7.52.8. Should be fixed in our repo by https://github.com/microsoft/FluidFramework/pull/24599.
I think these started to fail at the same time that the t9s tests broke, which seems to have been caused by some change we made. Before being too quick...
> With the change in the Reporter.ts, errors are correctly logged using the table. Awesome! Can you confirm that things look right if there's a mix of successful and failing...
Bundle analysis and code coverage reports correctly published as artifacts for runs of the Build - client packages: https://dev.azure.com/fluidframework/public/_build/results?buildId=332354&view=artifacts&pathAsName=false&type=publishedArtifacts.
> But we haven't merged those PRs yet, right? So the baselines that it would generate won't be correct since we keep updating PRs. @jatgarg I'm not sure I follow....
It's hard for me to tell just by looking if the new configs are correct. Can you update that package so it has an npm script that lints it with...
> Also, is this express version locked to 4.21.1? If express releases another update/fix to 4.21.2, would we automatically get it? When we define our dependency ranges for express we...
[This PR](https://github.com/microsoft/FluidFramework/pull/23189) should fix one of the failing tests. The other one is [this one](https://github.com/microsoft/FluidFramework/blob/4e4b3e737a788dbd7dbb74c943db60bbd903640b/packages/utils/telemetry-utils/src/test/sampledTelemetryHelper.spec.ts#L249) in telemetry-utils. I looked into it, and the problem seems to be a weird interaction...
/azp run Build - build-common
I'm a bit curious because I believe I've gotten PACKAGES.md to regenerate at some point (probably when adding or removing packages during experiments) and I don't recall running `flub check...