Update development and CI to Node 20

[CraigMacomber]

Description

This updates most things from node 18 to 20. This does not update the Dockerfiles.

Breaking Changes

Developers should update to node 20.15.1 or newer. This is somewhat enforced via engines blocks in the package.json.

Reviewer Guidance

The review process is outlined on this wiki page.

[CraigMacomber]

This is failing on CI demonstrating that some fixes are needed to enable moving to node 20.

[CraigMacomber]

This is still a useful reference.

[alexvy86]

This PR should fix one of the failing tests.

The other one is this one in telemetry-utils. I looked into it, and the problem seems to be a weird interaction between sinon.useFakeTimers() and our custom performance object starting in Node20. In Node19 the test still passes, but in Node20 it doesn't anymore (using clock.tick() from Sinon's fake timers still makes the native performance.now() report time as if the fake ticks have elapsed, but our object now reports natural elapsed time).

There's another test which does basically the same thing as the failing one, but in this case the measuring is not done through our custom performance object, but directly with the native one, and that one doesn't run into issues.

I don't think we should update the failing test to also use the native performance object because it's used inside a class method that could end up being used in the browser, so using our (hopefully works-in-browser-and-in-node) performance object seems like the correct thing to do there. If it's the only blocking bit for moving to Node20, let's just skip it and capture a work item to look into it in more detail at some point.

[agarwal-navin]

The other one is this one in telemetry-utils. I looked into it, and the problem seems to be a weird interaction between sinon.useFakeTimers() and our custom performance object starting in Node20. In Node19 the test still passes, but in Node20 it doesn't anymore (using clock.tick() from Sinon's fake timers still makes the native performance.now() report time as if the fake ticks have elapsed, but our object now reports natural elapsed time).

@alexvy86 @CraigMacomber I started looking into this because I want our end-to-end tests to start using fake timers instead of real waits. I initially thought that it was related to this issue (https://github.com/sinonjs/fake-timers/issues/438) where performance was not overriden by the fake timers but that's not the case. peformance is overriden but the custom isomorphic performance is not overriden like Alex said. I am not sure how we can ensure that it is also overriden but I wanted to share what I did in case it gave you guys any idea.

https://github.com/sinonjs/fake-timers/issues/438

[CraigMacomber]

I was getting the errors described in https://vercel.com/guides/corepack-errors-github-actions on CI. To get the recommended (0.31 +) version of corepack, it seems like node 20.19 is required, so I am trying that version.

[alexvy86]

/azp run Build - build-common

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).