Alex Villarreal

Results 95 comments of Alex Villarreal

One thing I just ran into, is that this split might require more significant changes on our end to support, e.g. https://github.com/microsoft/FluidFramework/blob/main/packages/test/test-drivers/src/routerliciousTestDriver.ts#L57-L62

I think something's not right here 😄 ![image](https://github.com/microsoft/FluidFramework/assets/716334/666010f6-1f03-4da7-91ab-77653ea0ca8b)

Found one more thing we need to bring with this (could have done it with any of them really, because the relevant file is already getting analyzed as part of...

I noticed other places were already using the `async-lock` package so just used that too for this fix, and managed to write a unit test _that is not deterministic_, but...

> To make sure the code works, not something you can just ignore for your convenience. Absolutely, and if the failure had been due to a code problem, that's definitely...

Yeah, I looked for "buffer error" as well to see if it was coming from the library itself but couldn't find it. I'll make the suggested edit to the code...

Didn't take long to see it again, but printing the trace did not provide any additional information: ```console Trace at Object.readTree (/workspaces/FluidFramework/server/tinylicious/node_modules/.pnpm/[email protected]/node_modules/isomorphic-git/index.cjs:12653:15) at async getTree (/workspaces/FluidFramework/server/tinylicious/dist/routes/storage/git/trees.js:77:28) ``` I now added...