alexpott
alexpott
This is problematic because there are valid @todo in our code. So checking this would cause a fail. I think a better thing would be to add a @todo checker...
Two factor auth needs to be taken into account. Left comment on code.
Nice one @smmccabe - this is looking pretty good and very useful. One small question about whether to include the other waitFor* methods.
So none of the nightly php builds on travis are php 8.1 ... ho hum. So let's not pretend... here's the output from running the tests locally on PHP 8.1...
@njh PHP 8.1 has now hit RC2. It'd be great to land this and get a new release out so that projects that have EasyRDF as a dependency can have...
@njh PHP 8.1 has hit rc3 :)
@njh I've created #387 to make it easier to add PHP 8.1 testing - if that's merged before this one then I can add PHP 8.1 testing here.
@bircher I'll add it to this PR given a minute.
You can see the actions in action here - https://github.com/alexpott/easyrdf/actions/runs/1311440366
@jonathanjfshaw yep and it's returning what `document.body.textContent` in the browser console does. The point is that this is not what `\Behat\Mink\Driver\Selenium2Driver::getText()` returns and it is returning stuff that is not...