Alexander Markov
Alexander Markov
It could be hard to check the type of the expression when building the flow graph, as static types are not written into kernel binary, and `InferredTypeMetadata` provides inferred types...
@blaugold Thank you for implementing this optimization! You can add multiple `// VMOptions=...` lines to the header a test (after copyright and description) in order to run the test multiple...
@blaugold You can click on the `CREATE RELAND` button (upper right corner) on the original CL - it will create a new CL with those changes. Then you can download...
@blaugold The change was reverted because there are new failures on the bots which test hot reload: https://dart-ci.appspot.com/log/vm-kernel-reload-linux-debug-x64/dartk-reload-linux-debug-x64/9528/language_2/switch/backward_jump_test/1 See https://github.com/dart-lang/sdk/issues/49789 for the full list of failures. There are also crashes...
I was able to reproduce hot reload failure using ``` tools/test.py -n dartk-reload-linux-debug-x64 language_2/switch/fallthru_runtime_test ```
Created https://github.com/dart-lang/sdk/issues/49790 about the infra problem which prevented from catching those failures earlier.
Turned from flaky to RuntimeError again. Recent logs: ``` --- Command "app_jit" (took 37.000326s): DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart --snapshot=/b/s/w/ir/cache/builder/sdk/out/ReleaseX64/generated_compilations/app_jitk-linux-release-x64/runtime_observatory_2_tests_service_2_breakpoint_in_package_parts_class_file_uri_test/out.jitsnapshot --snapshot-kind=app-jit --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.packages /b/s/w/ir/cache/builder/sdk/runtime/observatory_2/tests/service_2/breakpoint_in_package_parts_class_file_uri_test.dart exit code: 0 stdout: Info: Compiling without sound null...
This test also turned from flaky to RuntimeError on `dartk-linux-release-simarm64` configuration. Log: ``` --- Command "vm_compile_to_kernel" (took 08.000414s): DART_CONFIGURATION=ReleaseSIMARM64 /b/s/w/ir/pkg/vm/tool/gen_kernel --no-aot --platform=out/ReleaseSIMARM64/vm_platform_strong.dill -o /b/s/w/ir/out/ReleaseSIMARM64/generated_compilations/dartk-linux-release-simarm64/runtime_observatory_2_tests_service_2_breakpoint_in_package_parts_class_file_uri_test/out.dill /b/s/w/ir/runtime/observatory_2/tests/service_2/breakpoint_in_package_parts_class_file_uri_test.dart -Dtest_runner.configuration=dartk-linux-release-simarm64 --packages=/b/s/w/ir/.dart_tool/package_config.json -Ddart.vm.product=false exit code:...
`service_2/async_generator_breakpoint_test/dds_1` turned flaky -> Timeout on `vm-kernel-optcounter-threshold-linux-release-ia32`. /cc @bkonyi
I think if we don't want to use structural equality for identity, then we will make `identical` on record useless for any practical purposes. It's probably fine as there is...