Alexander Markov
Alexander Markov
The test `service/evaluate_activation_test/instance/service` went flaky -> RuntimeError on `vm-linux-release-x64` configuration: ``` 00:13 [32m+0[0m[31m -1[0m: evaluate_activation_test_instance.dart (VM Service) [1m[31m[E][0m[0m Expected: '123' Actual: '' Which: is different. Expected: 123 Actual:
Passing `--enable-asserts` to `gen_snapshot` is not enough. Flutter tools and flutter engine need to pass this option consistently to * frontend_server * gen_snapshot * Dart VM options at runtime Also,...
@kajornsakp It is possible that this artificial example hits the limitation on the number of classes in a Dart program, which was significantly increased recently in https://github.com/dart-lang/sdk/commit/9182d5e5359988703a2b8a88c238f47a5295e18c. This limitation is...
@SunlightBro Thank you for reporting this bug. Could you post the source code for `$_ProjectDto` class from `package:photodoc/model/dto/project_dto.dart`?
I was able to reproduce the problem and will proceed with the investigation. Smallish standalone repro ```dart class OffsetDateTime {} class ImageImage {} class UserDto {} class CompanyCompany {} class...
Fix is on the way: https://dart-review.googlesource.com/c/sdk/+/280041.
The fix rolled into Flutter (`master` channel) in https://github.com/flutter/flutter/commit/6f9a896d7928970338ad0655feee09feff6d27c0.
@adamkoch You can follow https://github.com/dart-lang/sdk/issues/51223 for the status of the cherry-pick to stable. Once fix lands on the stable branch, it is going to be included into the next hotfix...
The code is awful in both cases. A lot of iterator code is not inlined. This is not a comparison of VM inlining vs manual inlining. This is actually a...
Unused context and closure allocations are not removed in this code because of the `try` / `finally`: allocation sinking optimization which removes unused allocations is disabled if there is a...