Alex Eagle
Alex Eagle
Yeah I had a general `wrapped_binary` concept that could do a bunch of little utility things, based on my "genrule is bestrule" principle. https://github.com/aspect-build/bazel-lib/pull/251 I haven't had time to come...
Sorry for the delay @aschlosberg - your proposal sounds good to me.
How important is this? Looking for issues I can close here.
I find that logic also fails under rules_rust which sets `PATH` to a single entry that doesn't include `dirname` or `realpath`: `PATH="bazel-out/k8-opt-exec-ST-13d3ddad9198/bin/external/rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools/rust_toolchain/lib/rustlib/x86_64-unknown-linux-gnu/bin" ...` Perhaps this is a rules_rust bug? I...
This wouldn't break you if you used GitHub's archive, which has only the repo name included but not the org. https://github.com/f0rmiga/gcc-toolchain/archive/ac745d4685e2095cc4f057862800f3f0a473c201.tar.gz for example. The URL format you've used to fetch...
@panuhorsmalahti are you still maintaining this plugin? In the meantime I'm just shelling out to tslint.
Thanks for replying! I'm making some more progress on it. --- I figured that I could add more codeowners() targets, one per pattern. It's workable but the problem is the...
nice! Take a look at all the comments in https://github.com/alexeagle/angular/blob/codeowners/.github/BUILD.bazel - that's what's left to make the same codeowners as Angular has now. I think this nesting feature is nicely...
Actually as I'm rolling it out it seems what I really want is ``` codeowners( name = "OWNERS.compiler", patterns = [ "guide/angular-compiler-options.md", "guide/aot-compiler.md", "guide/aot-metadata-errors.md", ], team = "@angular/fw-compiler", ) ```...
FYI, I still find it too difficult to register all the codeowners() rules with the generation target. What we really want is just add codeowners to a package and the...