Alex Eagle comments

Results 1034 comments of


                                            Alex Eagle

[FR]: Add support for runtime_toolchain_type for jq/yq/...

We didn't intend to provide jq or yq for the target platform, and from this issue I don't understand why that would be useful. the rules_oci `push.sh` you point to...

`copy_to_directory` includes all files as runfiles

I could imagine introducing a `data` attribute next to `srcs`, but it would be a breaking change to stop including the `srcs` in runfiles so I'm not sure that's feasible.

feat: expose toolchains

Since we have `tar` I'm generally supportive of adding more common tools

feat: expose toolchains

https://github.com/tweag/rules_sh is already maintained by some Nix experts 😉

feat: expose toolchains

I think the `toolchain_type`s have to go somewhere else https://github.com/bazel-contrib/SIG-rules-authors/issues/91

feat: expose toolchains

I don't see on this thread an answer to: why would you want to load the toolchain symbols independently from registering them? Any increase to the public API surface constrains...

[Bug]: key "freebsd_amd64" not found in dictionary

I don't think we have enough freebsd users to prioritize this ourselves, but we should definitely publish binaries for that platform. In the meantime you should be able to configure...

Refactor mtree_spec to vis encode filenames

Thanks Paul - I'm not sure when I'll get time to work on this, but I imagine you can already patch in this change in the spot you need it,...

Refactor mtree_spec to vis encode filenames

Tried this out locally on my linux machine (stock Ubuntu 22.04.4 LTS), and I don't have `vis` installed. So I think we need a hermetic binary we can fetch and...

[FR]: tar rule should support runfiles with symlinks

I think it's okay for this to slip to 2.1 as it's not a breaking change.