Alex Eagle
Alex Eagle
I don't know how to tell what settings are correct, if CI is green that's all I can go on. How many editors are officially supported here?
#5235 picks out the first part of this that can land independently
> Where do we opt in to formatting json? https://registry.bazel.build/docs/aspect_rules_lint/1.10.2#rule-languages "Some languages have dialects: - javascript includes TypeScript, TSX, and JSON." I dunno why you weren't formatting those files before,...
@npaun okay - looks like the reason so many files in the repo aren't formatted is you only applied https://github.com/cloudflare/workerd/pull/3054/files to the `src/` directory. Do you recall what was the...
I added a `.gitattributes` file so we can note the ones which aren't enforced yet. Then in a post-factoring we can burn this down one chunk at a time.
Added ``` alias( name = "run_clang_format", actual = ":format_C++_with_clang-format", ) ``` @fhanau I intentionally changed only the GHA flow in this PR, my hope is to vet it before we...
@fhanau could you tell me what's broken on the internal CI?
@hoodmane all of this happens during repository rule evaluation, so `filegroup` isn't a useful construct. I've struggled with a few formulations of this and haven't found anything simpler - in...
replaced by #5832 and/or 042fbb864d1c6f84d474b9ef14fc18dc17b26273
I'm sorry I disappeared here! TBH I'm not a great reviewer for this, I don't think I ever reviewed earlier versions (@gregmagolan wrote it originally and I think @thesayyn made...