workerd icon indicating copy to clipboard operation
workerd copied to clipboard

refactor(bazel): move pyodide to bzlmod

Open alexeagle opened this issue 3 months ago • 8 comments

alexeagle avatar Oct 03 '25 17:10 alexeagle

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot :tada:

github-actions[bot] avatar Oct 03 '25 17:10 github-actions[bot]

@fhanau could you tell me what's broken on the internal CI?

alexeagle avatar Oct 20 '25 20:10 alexeagle

@fhanau could you tell me what's broken on the internal CI?

I believe this will require an internal PR to go with it – I'll try to get to that tomorrow.

fhanau avatar Oct 20 '25 21:10 fhanau

Ok, integrating this with the internal repository will be more hairy than expected – @dom96 and @hoodmane are more with pyodide and should be able to help.

fhanau avatar Oct 21 '25 03:10 fhanau

Is there a way to do this without the duplication? It is really great having one source of truth for all of this stuff, the duplication is going to waste a very substantial amount of my time.

hoodmane avatar Oct 21 '25 16:10 hoodmane

For instance, maybe it's possible to make ~4 file_groups and expose those?

hoodmane avatar Oct 21 '25 16:10 hoodmane

@hoodmane all of this happens during repository rule evaluation, so filegroup isn't a useful construct.

I've struggled with a few formulations of this and haven't found anything simpler - in fact this PR isn't sufficient on its own since the repository is still defined in WORKSPACE which is going away for Bazel 9.

Having someone with pyodide familiarily pair with me as the Bazel expert is probably the right way to find a resolution - let's chat on Slack?

alexeagle avatar Oct 22 '25 22:10 alexeagle

The best (the only?) advice I have here to make things maintanable is to update pyodide build script to generate the pyodide include with all the necessary extensions. This way you will have full control of all the repositories and information won't be duplicated.

One can also imagine pyodide publishing a bzlmod-friendly package somewhere (central registry?) but that seems like a lot of work to me.

mikea avatar Nov 06 '25 21:11 mikea

replaced by #5832 and/or 042fbb864d1c6f84d474b9ef14fc18dc17b26273

alexeagle avatar Jan 06 '26 23:01 alexeagle