Alex Brainman
Alex Brainman
@claudiubelu , I suggest we add Windows GetAce API https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-getace instead of GetEntriesFromACL added in https://go-review.googlesource.com/c/sys/+/578976 . Everyone expects to find standard Windows API in `golang.org/x/sys/windows` package and not some...
@qmuntal Thank you for creating this proposal. I agree with your sentiment. I always supported this functionality https://github.com/golang/go/issues/49471#issuecomment-1017412932 . And it looks silly that Delve supports Go Windows minidumps, but...
> is it possible to know if WER will upload anything from within the process? I believe WER behaviour is controlled by these registry settings https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps (from @qmuntal message at...
I think we should accept these changes. @qmuntal it would help if you create new issues demonstrating problems you intend to fix. You mention #49471 , but I suspect there...
> To clarify: this is _only_ when `GOTRACEBACK=crash` is set, right? Correct. > It sounds like we are still waiting to find out what exactly is being proposed here. >...
What I also want to add to my comment above is that this feature was requested nearly 5 years ago in #20498. Brad labeled it as `NeedsFix` and Ian as...
> It says "This feature is not enabled by default." > Does that mean that you have to edit a registry setting to make GOTRACEBACK=crash work? GOTRACEBACK=crash will still output...
> @zx2c4 's suggestion to create a minidump should be considered also as a more privacy focused alternative. I don't know what you mean by "minidump". But I tested CL...
Thank you @dagood for creating this issue. I agree with Ian. It is just a bug in `mkwinsyscall` program. We should fix it. Perhaps we could even change `mkwinsyscall` to...
> I could give this a shot @alexbrainman, ... Sure. Go ahead. Unless @dagood or others already started working on this change. > ... would this fix just involve changing...