Alex Brainman

Results 215 comments of Alex Brainman

@tooilxui your new test fails ``` === RUN TestMSSQLIssue178 mssql_test.go:1977: people name missmatch, ?? != 張三 --- FAIL: TestMSSQLIssue178 (0.20s) FAIL ``` on my Linux computer ``` go version devel...

@tooilxui but now your new test (TestMSSQLIssue178) passes even if I revert your fix (https://github.com/alexbrainman/odbc/pull/180/commits/df72402fb9efb7169dade1c59e5991ba4ceb649c). Alex

@tooilxui sorry but I don't have time to debug this. And I don't speak Chinese. And I am unfamiliar with language specific features in MS SQL. So I don't know...

Your test succeeds if I revert the fix: ``` a@spot:~/src/github.com/alexbrainman/odbc$ git rev-parse HEAD 5b9fdf0f0dfabd0cc9739156689ae18ec283ba75 a@spot:~/src/github.com/alexbrainman/odbc$ git diff diff --git a/param.go b/param.go index 53f84d8..a4cff66 100644 --- a/param.go +++ b/param.go @@ -70,9...

> Both of these issues does not occur with unixODBC-2.3.6. Unfortunately, we can use only unixODBC-2.3.7 on the production environment. I have no suggestions for you. > Also, Is there...

Thanks for your contribution. Is it possible to add new test in `mssql_test.go` file that fails now, but passes if you change is submitted? Alex

@hawkaa thanks for sending this PR. But what is the problem that this change solves? It would be nice if you create an issue first describing the problem, and then...

@hawkaa thanks for creating the issue. Let's continue this conversation on PR #171. Alex

Thank you for creating this issue. I don't use `context` package myself, but other users of `github.com/alexbrainman/odbc` might use it. So it could be beneficial for them. You would have...

@rchapin thanks for creating this issue. But I see no benefits of adding git tags to this repo. When I use this package in some code, I just use git...