Alex Brainman

Results 216 comments of Alex Brainman

> Sorry for delay, i was very busy with my work those days, i will respond yours comments late today No worries. Take as long as you like. Alex

@NewtonRocha I could not wait for you to make your changes, so copied and adjusted your code. Feel free to comment here https://github.com/alexbrainman/printer/tree/fix1 Thank you. Alex

@mdaloia23 `github.com/alexbrainman/sspi` package is not designed to work on darwin. It only works on windows. Alex

Windows-only packages do work very well. But for mixed packages I never even bother to look on godoc.ord (Brad's example above is good). Maybe this does need UI change. Maybe...

> https://github.com/Microsoft/go-winio is pretty broken here too, unfortunately :( What is broken? https://godoc.org/github.com/microsoft/go-winio looks fine to me ![image](https://user-images.githubusercontent.com/9796621/59721015-9f16cd00-9263-11e9-8242-9828965b6b0d.png) > This issue has been kinda dead for a while but I'd...

> https://godoc.org/github.com/microsoft/go-winio/vhd vs https://github.com/microsoft/go-winio/blob/master/vhd/mksyscall_windows.go is one example. The problem with this package is that zvhd.go file will build as part of "any" OS. If you make it windows only, I...

> I assume the issue is mksyscall is missing the Windows-only annotation as well? Yes, mksyscall.go will be built for every single OS. Including Linux. I suspect godoc.org runs Linux....

> Since msg is stack allocated How do you know that msg is allocated on stack and does not escape to the heap? I do not know what Go version...

> I tried go build -gcflags "-m" and didn't see any output relating to msg, so I guess that means the variable stays on the stack? I do not know...

Probably, wouldn't be difficult to implement on windows. Both amd64 and 386 use same Windows API. As long as the rest of code is not 64-bit specific, I think windows-386...