odbc icon indicating copy to clipboard operation
odbc copied to clipboard

Published 20 hours ago • verified publisher icon alexbrainman

Implement RowsColumnTypeDatabaseTypeName

Open hawkaa opened this issue 3 years ago • 4 comments

Implement RowsColumnTypeDatabaseTypeName interface in order to return column types.

https://github.com/golang/go/blob/e22a14b7eb1e4a172d0c20d14a0d2433fdf20e5c/src/database/sql/driver/driver.go#L469-L477

hawkaa avatar Feb 01 '22 20:02 hawkaa

@vegarsti FYI

hawkaa avatar Feb 01 '22 20:02 hawkaa

Nice!

On Tue, 1 Feb 2022 at 21:26, Håkon Åmdal @.***> wrote:

@vegarsti https://github.com/vegarsti FYI

— Reply to this email directly, view it on GitHub https://github.com/alexbrainman/odbc/pull/171#issuecomment-1027256152, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLPSNPF4YC2PCYFIWFUPVLUZA6YVANCNFSM5NKF32AQ . You are receiving this because you were mentioned.Message ID: @.***>

vegarsti avatar Feb 01 '22 20:02 vegarsti

@hawkaa thanks for sending this PR.

But what is the problem that this change solves?

It would be nice if you create an issue first describing the problem, and then we can decide if your change is good solution to your problem.

Thank you.

Alex

alexbrainman avatar Feb 26 '22 23:02 alexbrainman

Hi @alexbrainman . I'm terribly sorry that this PR came out of nowhere. I created #174 and I hope that brings clarification.

hawkaa avatar Mar 07 '22 15:03 hawkaa