Alexandre Daubois comments

Results 65 comments of


                                            Alexandre Daubois

[DomCrawler] Support classes from the new DOM extension

@nielsdos I just compiled the latest PHP version and all test are green, finally! Thank you for coming up with this solution so quickly. :pray: It's in good shape now!...

[DomCrawler] Support classes from the new DOM extension

I extracted common parts in traits for every class as you advised @derrabus, as well as tests. It really simplifies the whole thing for sure. I think it is ready...

[DomCrawler] Support classes from the new DOM extension

I understand, thanks for pointing this out. Which approach would you advise to solve this problem?

[VarDumper] feat: function jd() to dump variables without html tags in json api call

Why calling this function `jd()`? I assume it stands for "JSON dump", however, looking at the code, there's no mention about JSON. I think you may instead set a new...

Support Symfony 7

Nothing new yet, waiting for the review 😊

Unfortunately, Symfony 7 has been out now for 7-8 months so we decided to switch to [petitpress/gps-messenger-bundle](https://packagist.org/packages/petitpress/gps-messenger-bundle) (as we only use the Google Pubsub part of enqueue, it was just...

Add explicit nullable types to PSR-17

Thank you for checking this David!

Add explicit nullable types to PSR-17

I'm fine providing the updated PR if the author of the current one is not able to, cc @Ayesh 🙂

Add explicit nullable types to PSR-17

I opened a PR to update the interface, its PHPDoc and bump minimal PHP version. If in the meantime the original author wants to update his PR, I'm totally OK...

BC break - While adding an entity of class %s with an ID hash of "3" to the identity map, another object of class %s was already present for the same

We ran into the same issue on some legacy code and it indeed fixed the problem on our side. Thanks @mpdude 👍