fig-standards icon indicating copy to clipboard operation
fig-standards copied to clipboard

Published 20 hours ago • verified publisher icon php-fig

Add explicit nullable types to PSR-17

Open alexandre-daubois opened this issue 10 months ago • 5 comments

In order to make this one pass 🙂

alexandre-daubois avatar Apr 12 '24 08:04 alexandre-daubois

Thank you for checking this David!

alexandre-daubois avatar Apr 12 '24 12:04 alexandre-daubois

@shadowhand we need you to call a vote to approve this, but before we need to fix https://github.com/php-fig/http-factory/pull/16 by bumping to PHP 7.1+. Let me know how you want to proceed.

Jean85 avatar Apr 12 '24 13:04 Jean85

I'm fine providing the updated PR if the author of the current one is not able to, cc @Ayesh 🙂

alexandre-daubois avatar Apr 12 '24 14:04 alexandre-daubois

I opened a PR to update the interface, its PHPDoc and bump minimal PHP version. If in the meantime the original author wants to update his PR, I'm totally OK to keep his 🙂

alexandre-daubois avatar Apr 15 '24 07:04 alexandre-daubois

@shadowhand we need you to call a vote to approve this.

The vote has been called.

shadowhand avatar Apr 15 '24 12:04 shadowhand