Alexandre Daubois
Alexandre Daubois
@samdark I **really** like how you managed filters! This is a great way to do this I didn't think of!
I like Charset very much! I find it clearer. I updated the PR. I kept the `encodings` constraint option name to match the name of the `mb_detect_encoding()` function argument.
Thank you for the review, comments are addressed :+1:
`final` suits me fine, added :+1:
Hi! Thank you for letting me know Simon, I'll provide a fix for this :slightly_smiling_face:
I investigated and found that the problem may be linked the inlined service. Indeed, declaring services this way totally works and passes 'second' to `$second`, not `$first`: ```php $services->set(ExampleService::class) ->factory(service(ExampleFactory::class))...
What about classes extending `stdClass` and also defining other properties, public or not, with getters/setters? Just casting the object with as it is done with `stdClass` wouldn't fully work, isn't...
Indeed my solution doesn't work as expected. I don't think that reverting the PR is the best solution, because it would fix a bug but reintroduce one in the codebase....
Seems to be a great solution indeed, I like it!
Thanks @nielsdos for this complete explanation! 🚀 I think waiting for https://github.com/nielsdos/php-src/pull/93 would help a lot in what's missing now in this PR. In the meantime, I'll have a look...