Factory named arguments wiring issue

[v-m-i]

Symfony version(s) affected

6.2.3 and 5.4.16

Description

If we have a factory that looks like this:

final class ExampleFactory
{
    public function __invoke(
        string $first = '',
        string $second = '',
    ): ExampleService
    {...}
}

And if we use it like this (based on Passing Arguments to the Factory Method documentation):

    $services->set(ExampleFactory::class);

    $services
        ->set(ExampleCommand::class)
        ->arg('$service',
                inline_service(ExampleService::class)
                ->factory(service(ExampleFactory::class))
                ->args(
                    [
                        '$second' => 'second',
                    ]
                )
        )

The factory will be called with

$factory('second');

instead of

$factory('', 'second');

Tested on 6.2.3 and 5.4.16, but it probably affects other versions too.

How to reproduce

Bug reproducer: https://github.com/v-m-i/symfony-argument-bug

Possible Solution

No response

Additional Context

No response

[OskarStark]

Did it work in a previous version of Symfony?

[v-m-i]

@OskarStark I've tested it on 6.2.3 and 5.4.16, but I can test some other versions if needed. What versions should I test?

[OskarStark]

Not sure, I just wanted to understand if it worked before and you experience any issues after upgrading a Symfony package to the mentioned version or if it never worked based on the documentation 👍🏻

[v-m-i]

Oh, yeah, I don't know if it worked before, 5.4. was the first time I've tried it.

[alexandre-daubois]

I investigated and found that the problem may be linked the inlined service. Indeed, declaring services this way totally works and passes 'second' to $second, not $first:

$services->set(ExampleService::class)
        ->factory(service(ExampleFactory::class))
        ->args([
            '$second' => 'second',
        ]);

    $services
        ->set(ExampleCommand::class)
        ->arg('$service', service(ExampleService::class))
        ->tag('console.command');

I unfortunately wasn't able to find the right fix for it, but I hope this will help 👍

[v-m-i]

Yeah, this works as a workaround, thanks!