Aleksandr Bezobchuk
Aleksandr Bezobchuk
Sounds like you're describing a dedicated SS layer. I'm definitely in favor of splitting SS + SC responsibilities from the IAVL! I would really really really love for all this...
@yihuang do you have a concrete proposal? I do agree that SS should not concern itself with versioning -- it has no need to. Seems like we're on the same...
Amazing. Do you have an ADR, spec or doc detailing the idea?
I see. We can consider and evaluate that approach as we refactor the store. I'm not sure we'll go exactly with that approach though.
I've reviewed and approved the latter two nice-to-haves
That error output doesn't seem right...you should be providing a `--from` flag. Have you tried that?
Ahh yes, you're right. That makes sense. Now the question is, why is the `key not found` error happening. Somewhere in the dry run flow, it's trying to get the...
Yes, `--dry-run` doesn't need access to the keyring because it simulates the tx and thus uses a dummy pubkey. It should still work as it doesn't need access to the...
@adu-crypto yeah any state migrations that are happening based on vesting accounts, I would say those migrations should happen in vesting 👍 Is this something that can easily be done...
You need to: 1. bump the consensus version in module.go (if it wasn't already) 2. implement the migration 3. write tests for the migration 4. Add the call to `AppModule#RegisterServices`