Aleksandr Bezobchuk

Results 409 comments of Aleksandr Bezobchuk

Either way, we should ensure the output goes to dev/null unless the invariants fail.

The hacked code in CacheKV and tm-db continuously seem to bite us in the ass...

Yeah, but also keep in mind the IAVL implementation states various invariants/contracts that must be held. So either we improve docs around this and state what is and is not...

But module account are still accounts though, right? In which case they would still have a balance. How do you suggest we treat module accounts now? Also, there are many...

Love to see this epic getting started, but it's paramount that we have clearly documented proposals and the motivation for them. We also might want to reference ADR-061 here too.

We're literally doing most of this now. The team has been working hard and diligently on improving tests. See the improvements we've made in mocking, dependency isolation, etc...I encourage you...

ACK -- Use `gotest.tools` V3 going forward 👍

@ryanchristo do you have an example of tests I can look at or even a test suite ideally I can look at? Last time I played with gotest it was...

Gotcha. Looks like we should stick with testify's `suite` and `require` utilization, for now at least...

Yup, pretty much! I just found testify's require API, e.g. `Require.NoError` and similar functions very useful. But we can switch to take advantage of parallel tests.