Alexander Fenster

Results 75 comments of Alexander Fenster

To add some details here. Client libraries use gRPC via the [gax](https://github.com/googleapis/gax-nodejs) layer, and that gax layer can send retries if the library is configured so. By 'configured so' I...

Thank you for the report @cmdshepard. We are working for the full support for long running operations in the Compute client, I'm expecting to release the changes within a week...

@losalex Logging library is the only library that makes use of the batching feature, so it could go either way, but it will be easier to implement it here in...

Hi @okunishinishi, thank you for the fix! Would you mind signing the CLA at https://cla.developers.google.com/ so we could proceed with this PR? Thank you!

This is a Node.js library, we don't officially support other environments. It's expected that it won't work if Node.js modules are not available. Having that said, the module _might_ work...

@feywind Yes, seems like I will need to add `Buffer` here: https://github.com/googleapis/gax-nodejs/blob/master/tools/compileProtos.ts#L141 - we do some serious hacking on the generated `protos.d.ts`. I will fix it (but probably not earlier...

@feywind This totally may be related to batching, in that case, the fix in #1087 could help.

Seems like a good idea! We never need it because we manage our bots using labels, but I can see how being able to leave review comment could be useful....

Since we are starting using Cloud Build more and might want to mass-comment PRs with `/gcbrun`, let's maybe consider this?

I looked into this and, unfortunately, GitHub does not seem to return checks status in the list PRs call. Making one or more API calls per each PR listed would...