Alec Holmes comments

Results 74 comments of


                                            Alec Holmes

Multiple listeners is not working with Golang XDS Client

@grobza was there a reason for closing that PR? It seems like the integration tests fail with that change so maybe someone can look into that?

server: use separate goroutines for sotw bidi streams (#530)

@rueian can you rebase your branch of what was merged? The PR this was based off of is now in main

server: use separate goroutines for sotw bidi streams (#530)

> Hi @alecholmez, could you review this if you have free time? Yes sorry will review this now

server: use separate goroutines for sotw bidi streams (#530)

@snowp can you actually give this a look too? I'd like more eyes on this

server: use separate goroutines for sotw bidi streams (#530)

ping @snowp

sotw: [#558] Support dynamic wildcard subscription in sotw-xds

Ah this is awesome thanks @valerian-roche. I'll start the review process on this now. Would you mind resolving those merge conflicts?

sotw: [#558] Support dynamic wildcard subscription in sotw-xds

@fxposter given our conversations in slack I think this is now nullified if we don't want to track state in sotw. Can you review real quick and confirm?

Move the cache watch API from channels to interfaces

I like the thought @jpeach. Can you drop a comment here with what the notification interface might look like?

Switch to new Go protobuf v2 module

+1 for this. We looked into this previously and I believe the action items were: - Update rules_go: https://github.com/bazelbuild/rules_go/issues/2522 - Update Envoy's internal bazel pipeline - Update the build script:...

Switch to new Go protobuf v2 module

> Oof, that does not look promising ... Yea... this is a big rabbit hole I went down a while back, might be worth revisiting though