Alec Holmes

Results 74 comments of Alec Holmes

I have a PR open for this now: https://github.com/envoyproxy/envoy/pull/21790

Okay looks like this pr: https://github.com/envoyproxy/envoy/pull/21790 got merged so we can now proceed here. @jpeach would you be interested in picking this back up?

@snowp We definitely want this, once the delta code lands I think it'd be worth while spending some time on really figuring out the performance gains of delta. Just an...

I think I'm going to take this next, we need to test the performance of what we have now. Utilizing the integration test with something like pprof to scrape for...

Excellent, myself and @dougfort might iterate on a design doc to see what we can come up with. We'll see what we can capture, theres a gold mine of data...

@snowp if we intend to utilize the integration tests for what we want, is it safe to assume we don't intend on doing any long term storage of this throughput...

Want to note that eventually we should use this benchmark to test code change too: https://github.com/envoyproxy/go-control-plane/pull/451

Just FYI this [PR](https://github.com/envoyproxy/go-control-plane/pull/476) enables profiling for cpu, lock contention (block), mutex switching, go routine spawning and memory usage. It currently runs off the integration test but to test throughput...

@snowp any input here? Hiromi has found that the go benchmarks aren't particularly accurate for detecting throughput here, did you have in mind a separate framework that we might need...

Hey @valerian-roche can you resolve those merge conflicts so I can start taking a look at this?