go-control-plane icon indicating copy to clipboard operation
go-control-plane copied to clipboard

sotw: [#558] Support dynamic wildcard subscription in sotw-xds

Open valerian-roche opened this issue 3 years ago • 3 comments

Akin to #559, this PR is adding support for the new envoy wildcard semantics in the context of the SOTW server It is also doing significant work merging logic between the delta and sotw parts, especially for shared objects like StreamState where we currently have different members representing the same functional concern based on the server used

The PR is quite large mainly due to:

  • large nb of tests added or updated
  • merge of stream state semantics between sotw and delta, and no longer relying on request resources for wildcard status in sotw
  • merge of accessors on stream state required aligning map[string]bool and map[string]struct{}. An implementation choice here was to align on map[string]struct{} to not alter delta as much as possible, but the revert can be done

I can rework it in multiple smaller PRs to handle some parts independently (mostly aligning the maps) if preferred by reviewers

valerian-roche avatar Jul 06 '22 18:07 valerian-roche

Ah this is awesome thanks @valerian-roche. I'll start the review process on this now. Would you mind resolving those merge conflicts?

alecholmez avatar Jul 11 '22 21:07 alecholmez

Hey @alecholmez I fixed the conflicts for the PR As it's quite big, I can split it a bit more if you prefer

valerian-roche avatar Jul 12 '22 20:07 valerian-roche

@fxposter given our conversations in slack I think this is now nullified if we don't want to track state in sotw. Can you review real quick and confirm?

alecholmez avatar Aug 08 '22 14:08 alecholmez

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 07 '22 16:09 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Sep 14 '22 16:09 github-actions[bot]