Martti T. comments

Results 364 comments of


                                            Martti T.

gzip response only if it exceeds a minimal length

and probably `gzipResponseWriter.buffer` needs to be pooled as we are already pooling `gzip.Writer`

Is there any way for adding a group to echo.Echo or echo.Group?

I do not think this will work - have you tested these inits? I think init is run before `main()` so the Echo instance that you are adding routes from...

Is there any way for adding a group to echo.Echo or echo.Group?

I personally think you are doing it way too complicated way. I usually have "RegisterRoutes" function in package and I call it where Echo resides and if there are subgroup...

Is there any way for adding a group to echo.Echo or echo.Group?

@JobberRT if you got this sorted out could you close this issue, please.

Domain labstack.com should redirect to echo.labstack.com instead of displaying a placeholder

this ticked belongs to @vishr.

Domain labstack.com should redirect to echo.labstack.com instead of displaying a placeholder

Anyway, Labstack is the company from where Echo was started but it does not mean that Labstack top domain is Echo domain or should be. So I am closing this...

RequestLogger middleware can log wrong status codes

First example could be fixed to set some other status code (ala http.StatusInternalServerError) when `err != nil`. It is little bit bettern than 200 but still incomplete has you application...

fatal error: concurrent map read and map write

I can not recreate panic but I can see that when duration is same this code has race condition - both goroutines will write to response and therefore output contains...

fatal error: concurrent map read and map write

In my opinion this problem is caused by sharing `echo.Context` instance between two goroutines and not making sure that writer used to respond header and body to client is only...

fatal error: concurrent map read and map write

Timeout as middleware is quite complex thing to solve and if you happen to have some upstream server doing proxing (Apache/Nginx/some K8 ingress) it is easier to have them handle...