Martti T.
Martti T.
I'll check it soon but there seems to be little bit too few tests for huge change like that. I see 3 things here: 1. performance: route is searched by...
but this is cool PR as splitting single tree into tree for each method is thing that I have thought about trying out. Note: allow header can be sent for...
@dmitrybarsukov and @ortyomka have you though of splitting these changes into multiple PRs. I do not think that changing method tree structure should be in same change as where from...
Note: support for different params names for same path is probably going to get merged way faster than tree changes. I engourage you to use `benchstat` to compare different solutions....
As ratelimiter middleware (default implementation) is wrapper around https://pkg.go.dev/golang.org/x/time/rate library and rate value goes directly to that library I think `the docs explains how a fractional rate.Limit is handled` would...
This is actual documentation https://pkg.go.dev/golang.org/x/time/rate#Limit
Changing from `rate.Limit` to `int*` would probably break others existing code. As this middleware just wraps `x/time/rate` code it would be best to add comments inside middleware where we have...
note to self: `e.Static` signature should be changed to `func (e *Echo) Static(prefix, root string, middleware ...MiddlewareFunc) *Route` so additional middlewares could be set
Those how are missing that feature in `v4` you can have a workaround. Workaround for middlewares would be to add group with middlewares and add static route to that. ```go...
Please see https://github.com/labstack/echo/pull/2122#issuecomment-1065904491