Alberto Cuesta Cañada
Alberto Cuesta Cañada
There is a failing test, which I don't think is related to this PR: ``` 2023-02-23T15:37:08.3105748Z Failing tests: 2023-02-23T15:37:08.3105923Z Encountered 1 failing test in src/test/YieldMath.t.sol:YieldMathTest 2023-02-23T15:37:08.3106561Z [31m[FAIL. Reason: YieldMath: >...
@ShubhSensei, thanks for your initial work on this, I gave it another go.
Working on retrieving the domain and message hashes from a simulation in 704
#783 does this, a different PR will get it on CI
Oh great, now it seems to be stuck. Could I get some help here?
Alright, CI passes, could we please get this merged into draft, @axic, @g11tech, @SamWilsn, @xinbenlv?
Also, maybe make this a bit more prominent or fix it. This was quite an adventure. https://github.com/ethereum/ERCs/issues/8
If there aren't any more comments, could we please get this merged, please? @axic, @g11tech, @SamWilsn, @xinbenlv
Henloooooo, could we please get this merged? @axic, @g11tech, @SamWilsn, @xinbenlv