ethereum-optimism
Enforce folder numbering
We should add a check in CI to ensure that within a task folder, the numbering of tasks is increasing and does not overlap.
ie. #200 currently introduces a new dir tasks/sep/009-fpac-upgrade which is incorrect since there is already a tasks/sep/009-presigned-pause.
This happens easily due to race conditions between new tasks, so we should automatically check for it.
Hey @ShubhSensei, are you still interested in working on this? If so, here is my thinking for what we should do:
- Add a new
script/utils/check-task-numbering.sh - This is a shell script that loops through every
tasks/{network}folder. These folders contain a bunch of tasks of the form{number}-{optionalOtherNumber-}{taskName} - We call
{number}-{optionalOtherNumber-}the task prefix - For each folder, ensure that every task prefix is unique
- Run this new shell script in CI
I think we should only check for uniqueness, and not for any type of ordering or incrementing pattern. This is because:
- Uniqueness is simpler
- We do not always add tasks in order, i.e. sometimes for a bundle of upcoming tasks we'll add task 018 before task 017 is ready, but we don't want to block task 018 from being merged
@maurelian what do you think of this spec?
Yes @mds1 of course... I'm on it 🫡 BTW, is their any other medium where I can solve my queries otherwise it'll take forever like this.
Thanks, assigned! And apologies for the slow response here, I had meant to come back to this after #152 was addressed but never did 😅
