Alberto Cuesta Cañada
Alberto Cuesta Cañada
The logic looks solid to me, a few style fixes now, please: We are mixing the naming conventions from the old fyToken.sol and EIP5095, let's move to the 5095 naming...
Disabled in governance proposals ([Arbitrum](https://github.com/yieldprotocol/strategy-v2), [Mainnet](https://github.com/yieldprotocol/governance-v2/pull/38)). To be fixed in the [Witch](https://github.com/yieldprotocol/vault-v2/pull/411) refactor.
Follow the [OFAC](https://go.chainalysis.com/chainalysis-oracle-docs.html) list instead of maintaining our own.
Please use `rc` versions to publish packages that don't pass CI. I published with `0.18.2-rc.0`, next one will be `0.18.2-rc.1`, and when we are certain the package works, then it...
Includes #335 and #362
Yeah, with the testing and the audits done it's probably too late to fix this. Maybe it will come useful in v4.
I've got another use case for this feature, which I originally described in #3845, and that now I'm moving here. When coding a test harness for live contracts, it is...
We just need to add a `require(yieldLadle.joins(assetId) == IJoin(address(0)), "Join already exists")`.
The README says "You’ll need to have Node 8.16.0 or Node 10.16.0", you actually need Node 10.22. `yarn` needs to be 1.22 or higher, the README seems to say that...
Includes: #5 - Please check assets are not absorbed when selling. #24 - The *Ratio parameters on init are useless. #25 - The remainder parameter on init is useless. #27...