Andreas Braun
Andreas Braun
That's subjective - while not optimal I believe annotations provide a nice balance between speed and "clean code feel". Returning to the topic, what would you suggest for the issue...
> all three Please let's leave out YAML. We're dropping support for YAML in ODM 2.0 and ORM 3.0.
> Seems doable, do you agree? Absolutely. @winterstefan can you make the changes for ODM? I can make the changes for ORM unless you prefer to do them as well...
@winterstefan still up to work on this PR or would you like someone else to finish up? Note that #558 brings in annotations for ODM, so we could take that...
Fair enough, I know just the guy to do it 😉
Note: this also applies to other repositories, not just EntityRepositories.
> I'd say that instead of making an exclusion for a one-off scenario that will solve itself with the next major release, doing a bulk update of pre-existing PRs (via...
I don’t think adding methods to the interface is a good idea, as it requires duplicating logic. IMO the only reason not to do it is “it’s a tough BC...
https://github.com/weirdan/doctrine-psalm-plugin was brought to my attention today. @weirdan would you be open to contributing the annotations to our libraries directly? We've added them to doctrine/collections, but I'd love to see...
A pull request to master is a great start. If you want we can discuss this tomorrow in the symfony-devs or doctrine Slack 👍