Andreas Braun

Results 235 comments of Andreas Braun

@fabpot I'll add this for DoctrineBundle 1.12 which will come out with Symfony 4.4. If anyone wants to contribute this for Hacktoberfest, please go ahead!

1. Using an empty interface is not unprecedented, see [`ServiceEntityRepositoryInterface`](https://github.com/doctrine/DoctrineBundle/blob/1.12.x/Repository/ServiceEntityRepositoryInterface.php). The interface will only cover ORM, as MongoDB ODM doesn't know any entity (document) listeners yet. See note 3 though....

So you would have an empty interface and then check whether a method exists to fetch the configuration? What's the advantage of that compared to separate interfaces?

> maybe we can put `getDefaultEntityListenerConfiguration` inside `EntityListenerInterface` if forcing one to create the method and `return [];` is not considered cumbersome. I prefer having explicit interfaces and document them...

On second thought, you're right: the configuration would simply be the same thing we're getting when getting the corresponding tag from the service. An array will do just fine. Thanks!

I like the last suggestion here: ```php interface ConfiguredEntityListenerInterface extends EntityListenerInterface { public static getDefaultEntityListenerConfiguration(): array; } ```

It is - I've just had less time to work on this than I'd hoped. I'll take care of open issues/PRs over the coming weeks - please stay tuned.

I've taken a look, and we will most likely not be able to fix this in 3.x. Reason is that the underlying classes from the Doctrine data-fixtures library don't support...

Reopening - we will create a new 2.0 release in time for ORM 3 and hopefully Symfony 3, so this is still relevant.

While taking a look, this requires some work in `symfony/doctrine-bridge`, as it relies on the class parameters to configure the correct classes for the various bundles. I'll see if I...