Andreas Braun

Results 235 comments of Andreas Braun

This interface has been moved to `doctrine/persistence` a while back, with `doctrine/common` requiring `doctrine/persistence`. This issue is about removing `doctrine/common` and replacing it with the individual packages. This will be...

> I think new features for 1.x are out of question at this point when refactoring for 2.0 is already ongoing. Disagree: with how unclear the timeline for 2.0 is,...

**Always** use the object manager from the event args, never inject one through the constructor. The event args will always contain the entity manager that triggered the event, while one...

While the BC break is definitely to be avoided, we'll have to think about how to solve this in the future: there were numerous feature requests that would've been nice...

> DoctrineFixturesBundle 3.4 Wait, what? The newest release of `doctrine/doctrine-fixtures-bundle` is 3.0.2, there's no 3.4 release (yet). Taking a look at LiipFunctionalTestBundle, it seems the 2.x release supports this version...

Pinging @Ocramius for his opinion on the matter - TBH ORM should really drop doctrine/common proxies and start using proxy-manager for this.

#483 already does some improvements in the docs for ODM, even though we weren't quite sure whether we'd want to use annotations or XML.

@dinamic See PR description: > Use `Doctrine\ODM\MongoDB\Mapping\Annotations` configuration (same as for ORM). As for Doctrine recommendations, we recommend using XML for libraries or when you want to decouple your domain...

One could argue that even using XML ties your domain logic to your mapping, but that's outside the scope here. I was merely stating the reason for the change.

> but IMO promoting annotations has done some harm here In that case, feel free to change the ORM documentation. The primary goal was to have consistent documentation and ensure...