Alberto Gomez
Alberto Gomez
> this PR appears to be abandoned, can it be closed? I would prefer not to close it yet as it is an alternative approach to https://github.com/apache/geode/pull/6874 as it is...
> Maybe the way to go here is to rewrite `QueryObserverHolder` as a class that hold a `ThreadLocal` and then have ALL other product classes such as `DefaultQuery` just use...
> this PR appears to be abandoned, can it be closed? It is not yet abandoned. It is pending from a discussion with @kirklund about it.
> Inlined a few comments. Overall looks like a good direction! Here are some general comments and tips: > > 1. Prefer interfaces over abstract methods. > > 2. Standardize...
> @albertogpz we need to extract out the TX batching specific elements form the `GatewaySenderEventImpl` object. I replaced it with a implementation defined [metadata](https://github.com/pivotal-jbarrett/geode/blob/wip/wan-spi/geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java#L183) object. See [`TxBatchMetadata`](https://github.com/pivotal-jbarrett/geode/blob/wip/wan-spi/geode-wan-txbatch/src/main/java/org/apache/geode/cache/wan/internal/txbatch/TxBatchMetadata.java) from my previous...
> this PR appears to be abandoned, can it be closed? It is not abandoned. Still waiting for comments after review changes. I have rebased the branch to remove the...