geode icon indicating copy to clipboard operation
geode copied to clipboard

Published 20 hours ago • verified publisher icon apache

[DRAFT DO NOT REVIEW] Make ObserverHolder thread safe by having a thread local observer member

Open albertogpz opened this issue 3 years ago • 3 comments

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • [ ] Is your initial contribution a single, squashed commit?

  • [ ] Does gradlew build run cleanly?

  • [ ] Have you written or updated unit tests to verify your changes?

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

albertogpz avatar Sep 20 '21 11:09 albertogpz

This pull request introduces 1 alert when merging 64fe5c2e4cc6934f12e62e5c355062dd1c164dc2 into c68a770431a042df899a28ae3b519f27edca3c21 - view on LGTM.com

new alerts:

  • 1 for Inconsistent synchronization of getter and setter

lgtm-com[bot] avatar Sep 20 '21 18:09 lgtm-com[bot]

this PR appears to be abandoned, can it be closed?

onichols-pivotal avatar Feb 05 '22 08:02 onichols-pivotal

this PR appears to be abandoned, can it be closed?

I would prefer not to close it yet as it is an alternative approach to https://github.com/apache/geode/pull/6874 as it is mentioned in the comments.

albertogpz avatar Feb 07 '22 08:02 albertogpz