Alexander Berl

Results 239 comments of Alexander Berl

> > when you merge a PR on Flow, you would have to remember to consult the Neos actions to see if it broke something. The feedback should IMO be...

@neos/upmergers wdyt? Should we have this in our builds? If so, should it be visible on each PR or only in merge commit builds (i.e. the `Actions` [tab](https://github.com/neos/flow-development-collection/actions))

Oh boi, using regex for parsing semantics is always doomed to fail at some point. Yes, the regex is definitely "too lax", but really, you can't correctly parse a context...

I think I'd prefer using proxy-manager if possible, as that already handles all the gotchas with generating full proxy classes correctly for specific common use cases and is well tested....

Best counter-argument from Robert against ProxyManager is the missing original class renaming (though that could somehow be solved) to allow `new OriginalClass()` to get a proxied instance and the missing...

As discussed with @sorenmalling and @bwaidelich we agreed to: - have annotation routes completely come before setting routes, in package loading order - keep this simple (no placeholder configurations, no...

> But I just realized something differently: The route cache won't be flushed when a route annotation is added/changed/removed. I think we need some additional file monitors for that to...

> > what if we create a hook into the ProxyClassBuilder::build() method [...] > > I guess that could work, but it might slow down the (already quite slow) proxy...

Ugh, okay, I need to continue this with a clear head at another time - `ping()` is a method of the `AllowedObjectsListener` and not the `PersistenceManager`...

Something like this should do for parser regexes: ```php $SCAN_PATTERN_SHORTHANDSYNTAX_ARRAYS = '/^ (?P # Start the recursive part of the regular expression - describing the array syntax { # Each...