flow-development-collection icon indicating copy to clipboard operation
flow-development-collection copied to clipboard

!!! FEATURE: update to `doctrine/dbal` version 3

Open dependabot[bot] opened this issue 4 years ago • 11 comments

update to doctrine/dbal version 3

  • doctrines json_array type is deprecated, therefore flow_json_array is based off of json type now
  • We use PSR6 caches now instead of the deprecated doctrine cache implementation
  • New Cache Flow_Persistence_Doctrine_Metadata for ORM class metadata

Related Neos adjustments: https://github.com/neos/neos-development-collection/pull/5161

Upgrade instructions

We require now version 3 of doctrine/dbal but still operate doctrine/orm in version 2. In case you depend on dbal directly you should not really need to adjust anything but you can have a look into their upgrade instructions: https://www.doctrine-project.org/2020/11/17/dbal-3.0.0.html

dependabot[bot] avatar Nov 29 '21 09:11 dependabot[bot]

A newer version of doctrine/dbal exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

dependabot[bot] avatar Apr 04 '22 09:04 dependabot[bot]

It seems something is wrong with the (expected) PhpUnit version, and that ping() call missing an argument looks interesting, too…

kdambekalns avatar Apr 04 '22 15:04 kdambekalns

Ugh, okay, I need to continue this with a clear head at another time - ping() is a method of the AllowedObjectsListener and not the PersistenceManager...

albe avatar Apr 04 '22 20:04 albe

Rebased on 9.0 so this can be continued but i dont actually what our plan is with all this doctrine stuff

// cc @bwaidelich @kitsunet

mhsdesign avatar Jan 15 '24 19:01 mhsdesign