Alexander Berl

Results 239 comments of Alexander Berl

I agree, though "less breaking" is still breaking soooo... 😬 To fix #3345 we can change the caller to use null-coalescing in 7.1.x and then decide if we do want...

> wouldnt be an exception be more justified, or a system log? I would agree if this weren't about the TranslationHelper. When you're building an application and translating it or...

Hi @hlubek , can you take a look at https://github.com/neos/flow-development-collection/pull/1817 and possibly clean that up? @fcool already invested quite some time into this and it was already prettyy far, but...

Would like to get this into 7.1 as a feature. Can someone merge master into this again and maybe adjust the docs as Karsten suggested?

Ignore the test failures for now. They should be easy to fix. I'd like to get feedback, if this is something that would get support from the rest of the...

This change itself won't cover setting the current Locale in the i18n service yet, but that will be easily doable in a follow-up in whichever way is then seen practical....

I intentionally avoided that to prevent coupling the MVC package to the i18n package, but I'm open to that. I would otherwise handle the conversion to `Locale` object inside the...

@sorenmalling it's just an architectural cleanness thing, because even though all packages belong to the core, we try to keep them as decoupled as possible, in order to be able...

So my main questions remaining are these: - should the locale argument in the ActionRequest be an `Locale` object - where should the LocaleRoutePart be placed? Inside i18n in the...

Yes, feedback is welcome and highly appreciated. Other than that it's mostly fixing/adding tests what is keeping this "WIP". If we can land this in 5.1 I'm happy, if not...