Alan Paxton
Alan Paxton
I've confirmed that in 6.1.0-SNAPSHOT the original reported cases DO NOT return an error; this is correct behaviour. I will investigate whether there is still a more general problem with...
> Adam suggested I append this here as a related error. > > This query should raise an error, but it does not at the moment: > > ``` >...
This has been passed to me to take a further look at. I can generate a similar crash, but haven't been able to build/run 6.4.6 (and there have been code...
Hi John, Thanks for getting back to me. A self-contained program that reproduces the fault, even if I have to run it for a long time, would be ideal. Failing...
Hi John, Further thoughts @jcalcote - could this be happening at the same time / for the same reason as the failovers in your issue https://github.com/facebook/rocksdb/issues/7288 ? Judging by where...
I'd suggest a minimal test to add in FilterTest.java - set the policy to ribbon filter, read back the policy, confirm it is as expected.
Other than adding some test, LGTM
Hi @Harpuia - I just wanted to check that you've seen the comments..
Hi @siying @adamretter has asked me to review this on his behalf. Could you approve the workflows so we can sanity check that the builds (MSVC and the rest) are...
Hi @danielen1337 - thinking about tests. This looks like something that would be tricky to test in a CI way; would come down to timing a test and needing specific...