Alan Paxton
Alan Paxton
Hi @danielen1337; see above failed check. You need to "$ make format" on your branch to ensure that it conforms to the formatting requirements.
Hi @siying @kobykahane @adamretter this LGTM, format has been fixed, but needs someone to approve workflows on the contributor so that the CI can run.
Hi @charleswei19 In order to be able to fix this we need to know how you are calling the API (which method, parameters supplied to the method) - ideally a...
@siying Could you clarify for me if @guyuqi fix https://github.com/facebook/rocksdb/pull/7233 resolves this entire issue ? I want to know if I (as the inheritor of sike's work) should pick it...
I have acquired a Pi 4 B and explicitly built the shared lib at HEAD with nocrypto (-march=armv8-a+crc+nocrypto) instead of the current default of (-march=armv8-a+crc+crypto). In both cases, the symbols...
I wonder if @ajkr or @pdillinger could help me here ? When I call the optimized version of `db->MultiGet()` with `verify_checksums` set (https://github.com/facebook/rocksdb/blob/main/include/rocksdb/db.h#L691) it appears that `BLOCK_CHECKSUM_COMPUTE_COUNT` is not updated,...
Thank you @dtanner - I think it's just a straightforward error on our part; I'll see if I can organise a fix just now..
FYI @dtanner this was fixed in the PR https://github.com/facebook/rocksdb/pull/12167 - are you using the most recent released version of rocksdbjni ?
And of course it turns out that there are related issues in other RocksDB subclasses, plus a lot of inconsistency . I have addressed these in https://github.com/facebook/rocksdb/pull/12417
Hi @ChiragGangwani If you could provide further details of what you are doing, with a reproduction if possible, plus platform and RocksDB version you are using, it would make it...