Andrew Lamb
Andrew Lamb
Maybe @ankrgyl has some comments about this (I believe he added support for `trailing_commas`)
> I'm being helped by this project, so I would continuous contribution for it. Thanks @sivchari -- I think what would be most helpful is to help review PRs as...
Here is another proposal: https://github.com/sqlparser-rs/sqlparser-rs/issues/1139
I took the liberty of merging up from main to get CI to pass
Hi @AndrewChubatiuk -- the tests are failing on this PR -- can you please fix them?
This PR has some feedback that needs implementing, so marking it as draft. Please mark it as ready for review when it is next ready.
Thank you @ankrgyl -- I really appreciate you pushing this project along. > I would suggest changing the type of TokenizerError and ParserError to be richer than a string, and...
> The basic idea is that each individual arm of the Expr enum is responsible for tracking its location, instead of changing Expr to be a struct. Got it --...
I believe this would fall under a "semantic" check as described in https://github.com/sqlparser-rs/sqlparser-rs#syntax-vs-semantics Thus I think checking for this kind of error is probably best done somewhere other than sql-parser...
Thank you for the report @tooptoop4