Andrew Lamb

Results 1766 comments of Andrew Lamb

This PR is more than 6 month old, so closing it down for now to clean up the PR list. Please reopen if this is a mistake and you plan...

This PR is more than 6 month old, so closing it down for now to clean up the PR list. Please reopen if this is a mistake and you plan...

To be clear, I think the outcome of implementing the plan described by @crepererum in https://github.com/apache/arrow-datafusion/issues/2723#issuecomment-1324876060 will be: 1. Faster group by hash performance 2. More accurate memory usage accounting...

So I think this ticket now is a bit complicated as it was originally about avoiding two GroupBy operations which https://github.com/apache/arrow-datafusion/pull/4924 from @mustafasrepo does, but also has since grown to...

I filed https://github.com/apache/arrow-datafusion/issues/4973 to track consolidating the aggregators

It is actually quite cool to see that @crepererum 's plan from https://github.com/apache/arrow-datafusion/issues/2723#issuecomment-1324876060 is moving right along

I think we have chosen to focus on the arrow row format instead, and we removed the datafusion row format in https://github.com/apache/arrow-datafusion/pull/6968

Marking as draft as this is no longer waiting on comments