Ilya Kaznacheev
Ilya Kaznacheev
Turns out we have more than 10 tests which do exactly that - overwrite final fields. What should we do - should we update them all? @rogersimmons @RobAustin
I suggest doing that by default in 2.24 @minborg Should I reassign it to myself?
Only if they happen to use any optional enteprise dependencies or plugins.
Let's do warning now, error in 2.24?
Turns out we have more than 10 tests which do exactly that - overwrite final fields. What should we do - should we update them all? @rogersimmons @RobAustin
Nope, no real work is done yet, reopening.
Still flaky on Java 17
``` "main" #1 prio=5 os_prio=0 cpu=1773,11ms elapsed=2,01s tid=0x00007f0c58014fc0 nid=0x1780e8 runnable [0x00007f0c5cf82000] java.lang.Thread.State: RUNNABLE at net.openhft.chronicle.map.ChronicleMapBuilder.writeHeader(ChronicleMapBuilder.java:383) at net.openhft.chronicle.map.ChronicleMapBuilder.lambda$createWithFile$2(ChronicleMapBuilder.java:1721) at net.openhft.chronicle.map.ChronicleMapBuilder$$Lambda$74/0x0000000800c32f48.fileIOAction(Unknown Source) at net.openhft.chronicle.hash.impl.util.CanonicalRandomAccessFiles.lambda$tryRunExclusively$6(CanonicalRandomAccessFiles.java:193) at net.openhft.chronicle.hash.impl.util.CanonicalRandomAccessFiles$$Lambda$75/0x0000000800c33170.accept(Unknown Source) at net.openhft.chronicle.hash.impl.util.CanonicalRandomAccessFiles.lambda$acquire0$1(CanonicalRandomAccessFiles.java:72) at net.openhft.chronicle.hash.impl.util.CanonicalRandomAccessFiles$$Lambda$51/0x0000000800c277d8.apply(Unknown Source)...
Broken by commit ``` commit e6598e3723e04248670da493761326b36c45617a (HEAD) Author: Jerry Shea Date: Wed Aug 3 11:01:41 2022 +1000 undo
https://github.com/OpenHFT/Chronicle-Bytes/pull/455 a test for this issue