Chronicle-Wire icon indicating copy to clipboard operation
Chronicle-Wire copied to clipboard

HashWire is non-binary (text) wire which leads to object allocation, CPU usage

Open alamar opened this issue 4 years ago • 3 comments

We have HashWire used to calculate hash codes of SelfDescribingMarshallable, which is a text wire (it does not override isBinary() to return true). Which leads to easy 6-7x CPU usage as well as object allocations.

I guess we can't change it since it will affect existing objects' hash codes, which could be stored by our users. Maybe we can introduce a system property to make it use the binary form, which we will then make the default (in 2.23 or 3.X?)

alamar avatar Sep 22 '21 16:09 alamar

I personally think it is OK to change the hash value now, in x.22

JerryShea avatar Sep 23 '21 00:09 JerryShea

I suggest doing that by default in 2.24 @minborg Should I reassign it to myself?

alamar avatar May 03 '22 12:05 alamar

Please do @alamar

minborg avatar May 03 '22 13:05 minborg