Aarni Koskela

Results 594 comments of Aarni Koskela
trafficstars

You still have 755 files in this pull request. You'll probably need to `git reset 40e60a1f6cf178d9f57fcc14f157ea1b2ab77361` (the current `master`), then carefully `git add` only the changes you want, `git commit`...

> should i do all of this within the terminal in vscode where i was working? Maybe. I don't use Visual Studio Code much. Visual Studio Code might have other...

@sebas-inf If you're still around, please see the comments and rebase this to resolve conflicts. Thanks :)

Thanks! It would be nice to see a test for this, since the tests I wrote for #832 clearly didn't catch this typo 😅

@afh Do you have time to maybe look at this PR? Could get it merged for 2.16 :)

@afh No worries, thanks for replying! I can take this over, no problem.

There is no single configuration filename; you'd use ``` -F MAPPING_FILE, --mapping-file=MAPPING_FILE, --mapping=MAPPING_FILE path to the mapping configuration file ``` to specify one when running a Babel CLI command. This...

> The Unix tests are the only ones that use `pyfakefs`, so I can probably replace that with `os.chroot`. That sounds a bit heavy-handed too... What if you just `mock.patch`...

Sounds like a good idea. If you feel like writing a PR to implement this, feel free to!